Salut Didier,
On Fri, Oct 23, 2020 at 5:45 PM Didier Pallard <didier.pall...@6wind.com> wrote:
>
> Dependency on kmod needed to manage crypto devices is missing
> in qat crypto pmd.
>
> Cc: sta...@dpdk.org
> Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo")
The Fixes: tag goes first, then Cc:, then empty line.
> Signed-off-by: Didier Pallard <didier.pall...@6wind.com>
> ---
> drivers/common/qat/qat_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
> index b050ce20e4fc..9fa142b5e5bb 100644
> --- a/drivers/common/qat/qat_device.c
> +++ b/drivers/common/qat/qat_device.c
> @@ -423,3 +423,4 @@ qat_comp_dev_destroy(struct qat_pci_device *qat_pci_dev
> __rte_unused)
>
> RTE_PMD_REGISTER_PCI(QAT_PCI_NAME, rte_qat_pmd);
> RTE_PMD_REGISTER_PCI_TABLE(QAT_PCI_NAME, pci_id_qat_map);
> +RTE_PMD_REGISTER_KMOD_DEP(QAT_PCI_NAME, "* igb_uio | uio_pci_generic |
> vfio-pci");
> --
> 2.20.1
>
Reviewed-by: David Marchand <david.march...@redhat.com>
There are some other drivers that have the issue.
If there is a volunteer, we have other drivers with the same issue
(but probably worth double checking):
$ git grep -l 'drv_flags = RTE_PCI_DRV_NEED_MAPPING' drivers/ |xargs
dirname |sort -u|while read dir; do dir=${dir%%/base}; git grep -q
RTE_PMD_REGISTER_KMOD_DEP $dir || echo $dir; done
drivers/baseband/acc100
drivers/baseband/fpga_5gnr_fec
drivers/baseband/fpga_lte_fec
drivers/common/qat # done
drivers/event/octeontx
drivers/event/skeleton
drivers/mempool/octeontx
drivers/net/avp
drivers/net/hinic
drivers/net/octeontx
drivers/regex/octeontx2
--
David Marchand
