On Sat, Sep 05, 2020 at 08:38:46PM -0700, Stephen Hemminger wrote:
> We should be encouraging the use of vfio_pci for developers, not telling
> them to use igb_uio.
> 
> Also fix typo where .py suffix is visible in document.
> 
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
>  doc/guides/tools/devbind.rst | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/doc/guides/tools/devbind.rst b/doc/guides/tools/devbind.rst
> index a2910e103aab..52690f018648 100644
> --- a/doc/guides/tools/devbind.rst
> +++ b/doc/guides/tools/devbind.rst
> @@ -30,11 +30,11 @@ OPTIONS
>          Print the current status of all known network interfaces.
>          For each device, it displays the PCI domain, bus, slot and function,
>          along with a text description of the device. Depending upon whether 
> the
> -        device is being used by a kernel driver, the ``igb_uio`` driver, or 
> no
> +        device is being used by a kernel driver, the ``vfio_pci`` driver, or 
> no
>          driver, other relevant information will be displayed:
>          - the Linux interface name e.g. ``if=eth0``
> -        - the driver being used e.g. ``drv=igb_uio``
> -        - any suitable drivers not currently using that device e.g. 
> ``unused=igb_uio``
> +        - the driver being used e.g. ``drv=vfio_pci``
> +        - any suitable drivers not currently using that device e.g. 
> ``unused=vfio_pci``
>          NOTE: if this flag is passed along with a bind/unbind option, the
>          status display will always occur after the other operations have 
> taken
>          place.
> @@ -69,7 +69,7 @@ OPTIONS
>  
>  .. warning::
>  
> -    While any user can run the ``dpdk-devbind.py`` script to view the status 
> of the network ports,
> +    While any user can run the ``dpdk-devbind`` script to view the status of 
> the network ports,
>      binding or unbinding network ports requires root privileges.

Agree with all the replacements of igb_uio with vfio, but why remove the
.py suffix here? The script won't run without giving its full name, so this
removal seems unhelpful to the user.

Reply via email to