Reviewed-by: Wei Zhao <[email protected]>
> -----Original Message----- > From: dev <[email protected]> On Behalf Of Guinan Sun > Sent: Tuesday, May 12, 2020 4:13 PM > To: [email protected] > Cc: Sun, GuinanX <[email protected]>; [email protected] > Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control > mode > > The register autoneg can't be updated synchronously with flow control mode > setting in the state of port start , so NIC statistics error occurs. AUTO_NEG > Advt register should be updated by ixgbe_setup_fc() when enabling flow > control. > The patch fixes the issue. > > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > Cc: [email protected] > > Signed-off-by: Guinan Sun <[email protected]> > --- > v2 changes: > * Replaced mac.ops.setup_fc() with ixgbe_setup_fc() > * Modified commit message. > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index a4e5c539d..f8a84c565 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, > struct ixgbe_hw *hw) > int err; > uint32_t mflcn; > > + ixgbe_setup_fc(hw); > + > err = ixgbe_fc_enable(hw); > > /* Not negotiated is not an error case */ > -- > 2.17.1
