Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <[email protected]>
> Sent: Tuesday, May 5, 2020 11:13 AM
> To: Trahe, Fiona <[email protected]>; [email protected]
> Cc: [email protected]; Doherty, Declan <[email protected]>; 
> [email protected];
> [email protected]; Zhang, Roy Fan <[email protected]>; 
> [email protected];
> [email protected]; [email protected]; Gagandeep Singh 
> <[email protected]>; Hemant
> Agrawal <[email protected]>; [email protected]; De Lara Guarch, 
> Pablo
> <[email protected]>
> Subject: RE: [PATCH 1/9] cryptodev: add feature flag for non-byte aligned data
> 
> Hi Fiona,
> >
> > Hi Akhil,
> >
> > >
> > > Some wireless algos like SNOW, ZUC may support input
> > > data in bits which are not byte aligned. However, not
> > > all PMDs can support this requirement. Hence added a
> > > new feature flag RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA
> > > to identify which all PMDs can support non-byte aligned
> > > data.
> > [Fiona] I know it's a bit pedantic, but shouldn't this really be called
> > NON_BYTE_MULTIPLE?
> >
> > As a non-byte-multiple data set could have its start byte-aligned, but 
> > still not be
> > supported.
> >
> The intention is to have both start as well as end to be byte aligned.
> Is there some PMD which can support unaligned byte data but still multiples 
> of byte?
[Fiona] no, true - anything which can support non-byte-aligned can presumably 
support non-byte-multiples.
So I withdraw my suggestion. In that case:
Acked-by: Fiona Trahe <[email protected]>
 
> BTW I did not see any example in the current test cases which support 
> unaligned bytes data.
> 
> Regards,
> Akhil

Reply via email to