> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Friday, April 17, 2020 5:39 PM > To: Joyce Kong <[email protected]> > Cc: [email protected]; Stephen Hemminger > <[email protected]>; David Marchand > <[email protected]>; Morten Brørup > <[email protected]>; [email protected]; Richardson, Bruce > <[email protected]>; Ravi Kumar <[email protected]>; > Rasesh Mody <[email protected]>; Shahed Shaikh > <[email protected]>; Ziyang Xuan <[email protected]>; > Xiaoyun Wang <[email protected]>; Guoyang Zhou > <[email protected]>; Honnappa Nagarahalli > <[email protected]>; Gavin Hu <[email protected]>; Phil > Yang <[email protected]>; nd <[email protected]>; dpdk-dev <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of > common bit operation APIs > > On Thu, Apr 16, 2020 at 11:09 AM Joyce Kong <[email protected]> wrote: > > > > Bitwise operation APIs are defined and used in a lot of PMDs, which > > caused a huge code duplication. To reduce duplication, this patch > > consolidates them into a common API family. > > > > Signed-off-by: Joyce Kong <[email protected]> > > Reviewed-by: Gavin Hu <[email protected]> > > Reviewed-by: Phil Yang <[email protected]> > > Acked-by: Morten Brørup <[email protected]> > > --- > > MAINTAINERS | 4 + > > doc/api/doxy-api-index.md | 5 +- > > lib/librte_eal/include/meson.build | 1 + > > lib/librte_eal/include/rte_bitops.h | 258 > > ++++++++++++++++++++++++++++ > > 4 files changed, 266 insertions(+), 2 deletions(-) create mode > > 100644 lib/librte_eal/include/rte_bitops.h > > > > diff --git a/MAINTAINERS b/MAINTAINERS index 4800f6884..1d5fad28b > > 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -241,6 +241,10 @@ M: Cristian Dumitrescu > > <[email protected]> > > F: lib/librte_eal/include/rte_bitmap.h > > F: app/test/test_bitmap.c > > > > +Bitops > > +M: Joyce Kong <[email protected]> > > +F: lib/librte_eal/include/rte_bitops.h > > + > > MCSlock - EXPERIMENTAL > > M: Phil Yang <[email protected]> > > F: lib/librte_eal/include/generic/rte_mcslock.h > > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md > > index dff496be0..b63e782ec 100644 > > --- a/doc/api/doxy-api-index.md > > +++ b/doc/api/doxy-api-index.md > > @@ -9,6 +9,7 @@ API {#index} > > The public API headers are grouped by topics: > > > > - **device**: > > + [bitops] (@ref rte_bitops.h), > > IMO, It may not come in "device" section, instead existing "**basic** section > is more appropriate.
Will change to '**basic** section' in v9.
