Re: [dpdk-dev] [PATCH 2/3] app/test: fix building with GCC 10

[Medvedkin, Vladimir]

On 05/02/2020 12:50, Timothy Redaelli wrote:

GCC 10 defaults to -fno-common, this means a linker error will now be
reported if the same global variable is defined in more than one
compilation unit.

Fixes: 08e0c7581468 ("test/fib: add performance autotests")
Cc: vladimir.medved...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Timothy Redaelli <tredae...@redhat.com>
---
  app/test/test_fib_perf.c | 2 +-
  app/test/test_lpm_perf.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_fib_perf.c b/app/test/test_fib_perf.c
index 573087c3c..dd2e54db8 100644
--- a/app/test/test_fib_perf.c
+++ b/app/test/test_fib_perf.c
@@ -35,7 +35,7 @@ struct route_rule {
        uint8_t depth;
  };

-struct route_rule large_route_table[MAX_RULE_NUM];

+static struct route_rule large_route_table[MAX_RULE_NUM];

static uint32_t num_route_entries;

  #define NUM_ROUTE_ENTRIES num_route_entries
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index a2578fe90..489719c40 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -34,7 +34,7 @@ struct route_rule {
        uint8_t depth;
  };

-struct route_rule large_route_table[MAX_RULE_NUM];

+static struct route_rule large_route_table[MAX_RULE_NUM];

static uint32_t num_route_entries;

  #define NUM_ROUTE_ENTRIES num_route_entries

Acked-by: Vladimir Medvedkin <vladimir.medved...@intel.com>

--
Regards,
Vladimir