On 1/28/2020 9:01 PM, Ajit Khaparde wrote: > From: Kalesh AP <[email protected]> > > return value stored in "ret" but it has been overwritten before use. > > CID 353621: Code maintainability issues (UNUSED_VALUE) > Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") > Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") > Cc: [email protected] > > Signed-off-by: Kalesh AP <[email protected]> > Reviewed-by: Ajit Khaparde <[email protected]> > Signed-off-by: Somnath Kotur <[email protected]>
Hi Kalesh, The patch title doesn't really say much, it should say the actual reason not just fixing a tools warning, I am updating it as: "net/bnxt: fix return value check" Also the defined syntax for Coverity issues is: Coverity issue: #### For this case it should be: Coverity issue: 353621
