Sure Jerin. Regards Abhinandan
> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Thursday, October 3, 2019 8:54 AM > To: Hemant Agrawal <[email protected]> > Cc: dpdk-dev <[email protected]>; Jerin Jacob <[email protected]>; Gujjar, > Abhinandan S <[email protected]> > Subject: Re: [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value > for > AES algo > > On Tue, Oct 1, 2019 at 5:06 PM Hemant Agrawal <[email protected]> > wrote: > > > > The IV was not set, which was causing HW based SEC on DPAA1 to fail. > > > > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") > > > > Signed-off-by: Hemant Agrawal <[email protected]> > > Abhinandan, > > Could you please review the crypto adapter fixes, I would like to pull this > for RC1 > if possible. > > > > --- > > Please squash if possible. > > > > app/test/test_event_crypto_adapter.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/app/test/test_event_crypto_adapter.c > > b/app/test/test_event_crypto_adapter.c > > index 652e458f0..bf83a6357 100644 > > --- a/app/test/test_event_crypto_adapter.c > > +++ b/app/test/test_event_crypto_adapter.c > > @@ -171,6 +171,7 @@ test_op_forward_mode(uint8_t session_less) > > struct rte_event ev; > > uint32_t cap; > > int ret; > > + uint8_t cipher_key[17]; > > > > memset(&m_data, 0, sizeof(m_data)); > > > > @@ -186,6 +187,11 @@ test_op_forward_mode(uint8_t session_less) > > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC; > > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > + cipher_xform.cipher.key.data = cipher_key; > > + cipher_xform.cipher.key.length = 16; > > + cipher_xform.cipher.iv.offset = IV_OFFSET; > > + cipher_xform.cipher.iv.length = 16; > > + > > op = rte_crypto_op_alloc(params.op_mpool, > > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > > TEST_ASSERT_NOT_NULL(op, > > @@ -364,6 +370,7 @@ test_op_new_mode(uint8_t session_less) > > struct rte_mbuf *m; > > uint32_t cap; > > int ret; > > + uint8_t cipher_key[17]; > > > > memset(&m_data, 0, sizeof(m_data)); > > > > @@ -379,6 +386,11 @@ test_op_new_mode(uint8_t session_less) > > cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC; > > cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > > > + cipher_xform.cipher.key.data = cipher_key; > > + cipher_xform.cipher.key.length = 16; > > + cipher_xform.cipher.iv.offset = IV_OFFSET; > > + cipher_xform.cipher.iv.length = 16; > > + > > op = rte_crypto_op_alloc(params.op_mpool, > > RTE_CRYPTO_OP_TYPE_SYMMETRIC); > > TEST_ASSERT_NOT_NULL(op, "Failed to allocate crypto_op!\n"); > > -- > > 2.17.1 > >
