Hi Michal,
You also missed doc/guides/nics/ena.rst
Regards,
Hemant
> -----Original Message-----
> From: Michał Krawczyk <[email protected]>
> Sent: Friday, September 27, 2019 1:46 PM
> To: Hemant Agrawal <[email protected]>
> Cc: Ferruh Yigit <[email protected]>; Maciej Bielski
> <[email protected]>; [email protected]; Marcin Wojtas
> <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin
> <[email protected]>; Chauskin, Igor <[email protected]>
> Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to SPDX tags
> Importance: High
>
> + Igor
>
> pt., 27 wrz 2019 o 07:32 Hemant Agrawal <[email protected]>
> napisał(a):
> >
> >
> > > -----Original Message-----
> > > From: dev <[email protected]> On Behalf Of Ferruh Yigit
> > > Sent: Thursday, September 26, 2019 11:17 PM
> > > To: Maciej Bielski <[email protected]>; [email protected]
> > > Cc: Marcin Wojtas <[email protected]>; Michal Krawczyk
> > > <[email protected]>; Guy Tzalik <[email protected]>; Evgeny
> > > Schemeilin <[email protected]>
> > > Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to
> > > SPDX tags
> > >
> > > On 9/26/2019 1:31 PM, Maciej Bielski wrote:
> > > > Signed-off-by: Maciej Bielski <[email protected]>
> > > > Acked-by: Michal Krawczyk <[email protected]>
> > >
> > > <...>
> > >
> > > > diff --git a/drivers/net/ena/meson.build
> > > > b/drivers/net/ena/meson.build index 091ca6e3f..c7e71f494 100644
> > > > --- a/drivers/net/ena/meson.build
> > > > +++ b/drivers/net/ena/meson.build
> > > > @@ -1,5 +1,6 @@
> > > > # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2018
> > > > Intel Corporation
> > > > +# Copyright(c) 2015-2019 Amazon.com, Inc. or its affiliates.
> > > > +# All rights reserved.
> > > >
> > >
> > > This part is changing the copyright owner, it is under the ena
> > > driver but still is there a reason to change the owner?
> > >
> > > Overall this is a meson file, I personally don't see the meaning of
> > > having a copyright in a meson file, but trying to be fair.
> > >
> > > Would you mind keeping the original copyright for the file?
> > [Hemant] Not sure, if you kept the Intel's copyright by mistake or you
> copied this file from other driver having Intel's copyright.
> > You may like to keep add yours, but not delete the old one.
>
> Ok, let's keep the Intel's copyright.
>
> Thanks,
> Michal
