> -----Original Message-----
> From: Bruce Richardson <[email protected]>
> Sent: Monday, September 9, 2019 4:01 AM
> To: Stephen Hemminger <[email protected]>
> Cc: Honnappa Nagarahalli <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/ring: add template to support
> different element sizes
>
> On Sun, Sep 08, 2019 at 08:44:36PM +0100, Stephen Hemminger wrote:
> > On Fri, 6 Sep 2019 14:05:06 -0500
> > Honnappa Nagarahalli <[email protected]> wrote:
> >
> > > Add templates to support creating ring APIs with different ring
> > > element sizes.
> > >
> > > Signed-off-by: Honnappa Nagarahalli <[email protected]>
> > > Reviewed-by: Dharmik Thakkar <[email protected]>
> > > Reviewed-by: Gavin Hu <[email protected]>
> > > Reviewed-by: Ruifeng Wang <[email protected]>
> >
> > Understand the desire for generic code, but macro's are much harder to
> > maintain and debug. Would it be possible to use inline code taking a
> > size argument and let compiler optimizations with constant folding do the
> same thing.
> >
> > Sorry, I vote NO for large scale use of macro's.
>
> I would tend to agree. This use of macros makes the code very awkward to
> read and understand.
Stephen, Bruce, thank you for your feedback. Looks like we at least have an
agreement on the problem definition, hopefully we can find a solution. I will
try to rework this and get back with solutions/problems.
