> -----Original Message-----
> From: Nikhil Rao <nikhil....@intel.com>
> Sent: Friday, June 14, 2019 4:58 AM
> To: Jerin Jacob Kollanukkaran <jer...@marvell.com>
> Cc: nikhil....@intel.com; dev@dpdk.org
> Subject: [EXT] [PATCH v2] eventdev: change Rx adapter callback and stats
> structure
>
> ----------------------------------------------------------------------
> Replace the mbuf pointer array in the event eth Rx adapter callback with an
> event array. Using an event array allows the application to change attributes
> of the events enqueued by the SW adapter.
>
> The callback can drop packets and populate a callback argument with the
> number of dropped packets. Add a Rx adapter stats field to keep track of the
> total number of dropped packets.
>
> Signed-off-by: Nikhil Rao <nikhil....@intel.com>
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.h | 82 +++++++++++++-----
> -------- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 39 +++++++-----
> MAINTAINERS | 2 +-
> doc/guides/rel_notes/release_19_08.rst | 13 +++-
> lib/librte_eventdev/Makefile | 2 +-
1) Update version = 7 in lib/librte_eventdev/meson.build
2) remove the following
lib/librte_eventdev/Makefile:CFLAGS += -DALLOW_EXPERIMENTAL_API
lib/librte_eventdev/meson.build:allow_experimental_apis = true
3) Update the "git comment and release notes" to express the fact that
experimental
Status has been removed.
See following change set for reference.
commit 60df5711972e97d81cbfb811c9246f87cc69409a
Author: Harry van Haaren <harry.van.haa...@intel.com>
Date: Thu Apr 5 14:15:46 2018 +0100
service: remove experimental tags
> lib/librte_eventdev/rte_eventdev_version.map | 4 +-
> 6 files changed, 80 insertions(+), 62 deletions(-)
>
> v1:
> * add implementation to RFC
>
> v2:
> * Bump library version
> * Combine patch 1 & 2 into a single patch (single library version bump)
> * Mention API change in release notes
> * Remove __rte_experimental tag
> * Remove EXPERIMENTAL status for eventdev
>
> @@ -819,6 +806,26 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)
> ev++;
> }
>
> + if (dev_info->cb_fn) {
> +
> + dropped = 0;
> + nb_cb = dev_info->cb_fn(eth_dev_id,
> + rx_queue_id,
> + ETH_EVENT_BUFFER_SIZE,
> + buf->count,
> + ev,
> + num,
> + dev_info->cb_arg,
> + &dropped);
I think, the above variables can squash to 80 characters limit to reduce the
lines.
Other than, Above nits, The patch looks good to me.
