> -----Original Message----- > From: Luca Boccassi <bl...@debian.org> > Sent: Monday, June 3, 2019 4:48 PM > To: Jerin Jacob Kollanukkaran <jer...@marvell.com>; dev@dpdk.org > Cc: Satha Koteswara Rao Kottidi <skotesh...@marvell.com>; Vamsi Krishna > Attunuru <vattun...@marvell.com> > Subject: Re: [dpdk-dev] [PATCH v1 1/9] raw/octeontx2_dma: add build infra > and device probe > > On Sat, 2019-06-01 at 23:50 +0530, jer...@marvell.com wrote: > > diff --git a/drivers/raw/octeontx2_dma/meson.build > > b/drivers/raw/octeontx2_dma/meson.build > > new file mode 100644 > > index 000000000..1281268aa > > --- /dev/null > > +++ b/drivers/raw/octeontx2_dma/meson.build > > @@ -0,0 +1,18 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(C) 2019 Marvell > > +International Ltd. > > +# > > + > > +deps += ['rawdev', 'ring', 'kvargs', 'bus_pci', 'common_octeontx2', > > 'mempool_octeontx2'] > > +sources = files('otx2_dpi_rawdev.c') > > + > > +extra_flags = [] > > +# This integrated controller runs only on a arm64 machine, remove > > 32bit warnings > > +if not dpdk_conf.get('RTE_ARCH_64') > > + extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to- > > int-cast'] > > +endif > > + > > +foreach flag: extra_flags > > + if cc.has_argument(flag) > > + cflags += flag > > + endif > > +endforeach > > If it only works on 64bit, shouldn't the build be disabled for 32bit targets?
We just thought of enabling it for 32bit to _detect_ build regression for 32bit so that in future we can run with ILP32 if required. If you have strong option on this then we can disable it if required. > > -- > Kind regards, > Luca Boccassi