On Fri, May 24, 2019 at 1:38 PM Ferruh Yigit <ferruh.yi...@intel.com> wrote:
> On 5/21/2019 5:13 PM, Olivier Matz wrote: > > The rte_net headers conflict with the libc headers, because > > some definitions are duplicated, sometimes with few differences. > > > > This patchset adds the rte_ (or RTE_) prefix to all structures, functions > > and defines in rte_net library. This is a big changeset, that will > > break the API of many functions, but not the ABI. > > > > This was discussed in [1], and requested by the techboard [2]. > > > > patch-v1: > > * rease on top of v19.05 > > * remove uneeded renames in drivers/net/bonding/rte_eth_bond_pmd.c > > and app/test-pmd/icmpecho.c (arp-related variables) > > * do not modify base drivers, except cxgbe, thunderx, enetc, qede: > > only files that already contain dpdk definitions are modified. > > * fix checkpatch issues when it does not impact the code style too > > much. Big warnings remain about the RTE_IPv4() macros because > > arguments are separated by ',' instead of ', '. > > * add a release note patch > > * tested compilation on x86_64-linux and x86_64-freebsd. > > > > rfc-v2: > > * rebase on top of v19.05-rc1 > > > > > > [1] http://mails.dpdk.org/archives/dev/2018-January/087384.html > > [2] http://mails.dpdk.org/archives/dev/2019-February/125033.html > > > > > > Olivier Matz (15): > > net: add rte prefix to arp structures > > net: add rte prefix to arp defines > > net: add rte prefix to ether structures > > net: add rte prefix to ether functions > > net: add rte prefix to ether defines > > net: add rte prefix to esp structure > > net: add rte prefix to gre structure > > net: add rte prefix to icmp structure > > net: add rte prefix to icmp defines > > net: add rte prefix to ip structure > > net: add rte prefix to ip defines > > net: add rte prefix to sctp structure > > net: add rte prefix to tcp structure > > net: add rte prefix to udp structure > > doc: announce network api change > > Reviewed-by: Stephen Hemminger <step...@networkplumber.org> > Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> > > For series, > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Series applied to dpdk-next-net/master, thanks. > Sorry, late to the party... Since we change those defines, we might as well avoid these warnings: CHECK:CAMELCASE: Avoid CamelCase: <RTE_ETHER_TYPE_IPv4> CHECK:CAMELCASE: Avoid CamelCase: <RTE_ETHER_TYPE_IPv6> I can send a patch. -- David Marchand
