>-----Original Message----- >From: Ruifeng Wang [mailto:ruifeng.w...@arm.com] >Sent: Monday, April 29, 2019 3:02 AM >To: Wang, Yipeng1 <yipeng1.w...@intel.com>; Gobriel, Sameh ><sameh.gobr...@intel.com>; Richardson, Bruce ><bruce.richard...@intel.com>; De Lara Guarch, Pablo ><pablo.de.lara.gua...@intel.com> >Cc: dev@dpdk.org; jer...@marvell.com; honnappa.nagaraha...@arm.com; >n...@arm.com; Ruifeng Wang <ruifeng.w...@arm.com> >Subject: [PATCH v1] hash: simplify signature compare neon process > >Replaced multiple neon instructions with single equivalent instruction. >This made simpler code and a bit higher performance. >Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72 >platforms. > >Signed-off-by: Ruifeng Wang <ruifeng.w...@arm.com> >Reviewed-by: Gavin Hu <gavin...@arm.com> >--- [Wang, Yipeng] Sorry for the late review. The logic seems fine to me based on my understanding of the instructions. But I don't have an ARM machine to test. Please make sure It passes the compilation and unit tests. Or others (Jerin maybe?) could provide more feedback?
Acked-by: Yipeng Wang <yipeng1.w...@intel.com>
