On 4/24/2019 4:26 PM, Anatoly Burakov wrote: > In no-shconf mode, there is no need to clean runtime directory > because it's not created in the first place. > > Fixes: 0a529578f162 ("eal: clean up unused files on initialization") > > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Is this for 18.11.x LTS? cc'ed the stable mail list assuming that is the case. Is this valid for 19.05 too? > --- > lib/librte_eal/linuxapp/eal/eal.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c > b/lib/librte_eal/linuxapp/eal/eal.c > index 30138b638..59497d04a 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv) > * whether we are primary or secondary process, but we cannot remove > * primary process' files because secondary should be able to run even > * if primary process is dead. > + * > + * In no_shconf mode, no runtime directory is created in the first > + * place, so no cleanup needed. > */ > - if (eal_clean_runtime_dir() < 0) { > + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) { > rte_eal_init_alert("Cannot clear runtime directory\n"); > return -1; > } >