14/11/2018 04:24, Varghese, Vipin: > Tested-by: Vipin Varghese <[email protected]> > > <snipped> > > > >> When creating process data structures, EAL will create many files in > > >> EAL runtime directory. Because we allow multiple secondary processes > > >> to run, each secondary process gets their own unique file. With many > > >> secondary processes running and exiting on the system, runtime > > >> directory will, over time, create enormous amounts of sockets, > > >> fbarray files and other stuff that just sits there unused because the > > >> process that allocated it has died a long time ago. This may lead to > > >> exhaustion of disk (or RAM) space in the runtime directory. > > >> > > >> Fix this by removing every unlocked file at initialization that > > >> matches either socket or fbarray naming convention. We cannot be sure > > >> of any other files, so we'll leave them alone. Also, remove similar > > >> code from mp socket code. > > >> > > >> We do it at the end of init, rather than at the beginning, because > > >> secondary process will use primary process' data structures even if > > >> the primary itself has died, and we don't want to remove those before > > >> we lock them. > > >> > > >> Bugzilla ID: 106 > > >> > > >> Cc: [email protected] > > >> > > >> Reported-by: Vipin Varghese <[email protected]> > > >> > > >> Signed-off-by: Anatoly Burakov <[email protected]> > > Thanks Anatoly for the patch which clean-ups the tmpfs. This unblock the > client from critical stopper too. > > > > > > > I feel it is too big and too late for 18.11. > > > Can we move it to 19.02? > > > > From maintainer's point of view, i agree that it's too risky to merge into > > 18.11 > > at this stage. My input should probably stop there, but Vipin (the original > > bug > > reporter) may have other thoughts on this matter. > > Hi Thomas, without the fix it affects both dpdk and non dpdk application use > a host or VM. My suggestion to have the fix in and port to 18.11 LTS too.
It is changing a behaviour. I propose to test it on 19.02 and backport it in 18.11.1. Any other opinion?
