Copilot commented on code in PR #311:
URL: https://github.com/apache/doris-thirdparty/pull/311#discussion_r2062812917
##########
c++/src/Reader.cc:
##########
@@ -1341,6 +1348,7 @@ namespace orc {
prepareFollowReaders(footer->rowindexstride(),
currentRowInStripe, followRowInStripe),
sel_rowid_idx.get(), arg);
followRowInStripe = currentRowInStripe + rowsToRead;
Review Comment:
Setting data.numElements to rowsToRead clarifies the element count for
follow readers; consider adding an inline comment to explain the rationale
behind this update for future maintainability.
```suggestion
followRowInStripe = currentRowInStripe + rowsToRead;
// Update data.numElements to reflect the number of rows read in
this batch.
// This ensures follow readers process the correct number of
elements.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
