qidaye commented on code in PR #152:
URL: https://github.com/apache/doris-thirdparty/pull/152#discussion_r1429155059
##########
src/core/CLucene/index/IndexWriter.cpp:
##########
@@ -1515,9 +1506,9 @@ void
IndexWriter::addIndexesSegments(std::vector<lucene::store::Directory *> &di
{
SCOPED_LOCK_MUTEX(this->THIS_LOCK)
for (auto dir: dirs) {
- SegmentInfos sis;// read infos from dir
- sis.read(dir);
- segmentInfos->insert(&sis, true);
+ SegmentInfos* sis = new SegmentInfos(); // Create SegmentInfos
on heap
Review Comment:
`addIndexesSegments` is useless now. I'll delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
