I agree with you. I've modified it, using
https://github.com/diffplug/spotless/tree/main/plugin-maven#how-can-i-enforce-formatting-gradually-aka-ratchet


--

Best Regards

------------

Liugddx
liug...@gmail.com


Mingyu Chen <morning...@163.com> 于2023年10月5日周四 21:25写道:

> Hi Liu:
> This PR is too large and may be conflict with so many other PRs.
> Is there any way to just modify the incremental code, not existing code?
>
>
>
>
> --
>
> Best Regards
> Mingyu Chen
>
> Email:
> morning...@apache.org
>
>
>
>
>
> At 2023-10-01 17:28:53, "Guangdong Liu" <liug...@gmail.com> wrote:
> >Hi dev
> >
> >This is my PR, please help the community to review it. If anyone have any
> >questions just let me know and I will follow up. Thanks.
> >
> >https://github.com/apache/doris/pull/25033
> >
> >--
> >
> >Best Regards
> >
> >------------
> >
> >Liugddx
> >liug...@gmail.com
> >
> >
> >Mingyu Chen <morning...@163.com> 于2023年9月23日周六 21:19写道:
> >
> >> Good idea!
> >>
> >>
> >>
> >>
> >> --
> >>
> >> Best Regards
> >> Mingyu Chen
> >>
> >> Email:
> >> morning...@apache.org
> >>
> >>
> >>
> >>
> >>
> >> At 2023-09-21 19:16:16, "Guangdong Liu" <liug...@gmail.com> wrote:
> >> >Hi dev,
> >> >
> >> >I want to introduce spotless as a code formatting tool.Spotless has two
> >> >very convenient advantages:
> >> >
> >> >1. developers do `mvn spotless:check` command in local and just do the
> >> >commit in PR, It will automatically do code formatting. It can't avoid
> the
> >> >review in code when developer not do `mvn spotless:check` command.
> >> >
> >> >2. if in work flow add the check for reformat plugin, it will cause
> the ci
> >> >flow has some modifies need to commit.
> >> >
> >> >Looking forward to community responses.
> >> >
> >> >--
> >> >
> >> >Best Regards
> >> >
> >> >------------
> >> >
> >> >Liugddx
> >> >liug...@gmail.com
> >>
>

Reply via email to