Nobody has an objection here and 5 people agree. So that, we will begin to remove non-vectorization code now.
Gabriel Lee <[email protected]> 于2022年12月7日周三 19:08写道： > > +1. Make sense for both users and developers > > Best, > Gabriel > > On Tue, 6 Dec 2022 at 17:08, Mingyu Chen <[email protected]> wrote: > > > Agreed. > > The non-vec code can be maintained on branch-1.1-lts, and branch-1.2-lts. > > > > > > > > > > -- > > > > 此致！Best Regards > > 陈明雨 Mingyu Chen > > > > Email: > > [email protected] > > > > > > > > > > > > 在 2022-12-06 16:24:00，"BiteTheDDDDt" <[email protected]> 写道： > > >+1, it will be helpful > > > > > > > > > > > > > > >BiteTheDDDDt > > >[email protected] > > > > > > > > > > > > > > > > > > > > > > > > > > >------------------ 原始邮件 ------------------ > > >发件人: > > "dev" > > < > > [email protected]>; > > >发送时间: 2022年12月6日(星期二) 下午4:22 > > >收件人: "[email protected]"<[email protected]>; > > > > > >主题: Re: Remove non-vectorization code > > > > > > > > > > > >+1 > > > > > >在 2022/12/6 13:38，“vin jake”<[email protected]> 写入: > > > > > > +1 > > > It's enough to keep non-vectorization code just in > > 1.1-lts > > > It's time to remove non-vectorization code now in > > master > > > > > > On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi < > > [email protected]> wrote: > > > > > > > Hi All Developers, > > > > > > > > Vectorization is introduced into Doris in 1.0 > > which is released > > > > earlier this year. Many companies is using 1.1.x > > and it is very very > > > > Fast and Stable. I think it's time to > > remove non-vectorization code > > > > now. Following is my considerations: > > > > > > > > - Lots of company is using doris 1.1.x and it is > > stable. > > > > - 1.1-lts is a LTS branch, we will maintain it > > and fix bugs for it, If > > > > you need non-vectorization code, I think 1.1 will > > solve your problem. > > > > - 1.2 is now released, many features like array, > > JsonB, nest loop > > > > join, decimalv3, datev2 and etc. are not > > implemented on > > > > non-vectorization engine. So if a user is using > > 1.2 and using some new > > > > features then it could not rollback to > > non-vectorization engine any > > > > more. > > > > - We need to refactor some code but we need to > > maintain these > > > > non-vectorization code, it is very hard and it is > > very likely to > > > > import BUGs and there are not many developers > > could add feature or fix > > > > bugs for non-vectorization code. > > > > > > > > So that, I think it's time to remove > > non-vectorization code now to > > > > move Fast and Stable!!! > > > > > > > > -- > > > > Best Regards, > > > > Yi Guo Lei > > > > SelectDB > > > > The Best Cloud Native Platform for Apache Doris > > > > Tel:134-3991-0228 > > > > Email:[email protected] > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: > > [email protected] > > > > For additional commands, e-mail: > > [email protected] > > > > > > > > > > > > > > > > >--------------------------------------------------------------------- > > >To unsubscribe, e-mail: [email protected] > > >For additional commands, e-mail: [email protected] > > -- Best Regards, Yi Guo Lei SelectDB The Best Cloud Native Platform for Apache Doris Tel:134-3991-0228 Email:[email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
