Thanks Dave for your check. My reply is below. Dave Fisher <w...@apache.org> 于2019年10月22日周二 上午1:57写道：
> Hi - > > I am +1 (binding) > > Incubating in the name > DISCLAIMER is present. I recommend using the new DISCLAIMER-WIP. > I create an issue[1] to track it, we will fix it in 0.12 version > LICENSE is present and mostly proper. See notes. > NOTICE is present. > RAT Check mostly passes see below. > I did not check compilation. > > > On Oct 20, 2019, at 7:47 PM, Li,De(ACG Cloud) <l...@baidu.com> wrote: > > > > +1 > > > > I have checked: > > > > 1. Download links are valid. > > 2. Checksums and PGP signatures are OK. > > 3. DISCLAIMER is included. > > 4. Source code artifacts have correct names matching the current release. > > 5. LICENSE and NOTICE files are corrected. > > 6. All source files have license headers. > > 7. Build from source are OK in Docker environment. > > > > About License check by apache-rat, I used following command, it seems > more cleaner than written in > https://github.com/apache/incubator-doris/wiki/How-to-verify-Apache-Release > > > > # /usr/java/jdk/bin/java -jar apache-rat-0.12/apache-rat-0.12.jar -a -d > apache-doris-0.11.0-incubating-src -e *.md *.MD .gitignore .gitmodules > .travis.yml manifest **vendor** **licenses** | grep File: | grep -v > "test_data" | grep -v "gutil" | grep -v "json" | grep -v "patch" | grep -v > "xml" | grep -v "conf" | grep -v "svg" > > *.md and *.MD files should have Apache License Headers. > > Created an issue[2] to track it too. The license for some of the files copied from Apache Impala particularly in > be/src/gutil are a little unclear. Following the way that Impala does its > License might be an improvement. > > Created an issue[3] to track it too. HOWEVER. Is there any reason not to make Impala a dependency and take the > code from them directly? I did not do a comparison to see if there is > divergence. You may recall that Jim Apple from Impala had questions like > this during the Proposal stage. > Yes, we know Impala's community's questions. I think it's very very difficult to make Impala a dependency. Following is some of the reason. 1. Impala is not a library, the interface between Doris between Impala is not clear. It will be a lot of work to do if make Impala a dependency. 2. Doris is based on Impala 0.9 version or older and not keep up with Impala's improvement. So There is huge divergence between Impala and Doris. In my point of view, it's almost impossible to make Impala a dependency of Doris. I think the Impala community's concern is about that we have no feed back or contribution to Impala, we can contribute some of work which is also suitable for Impala later. > > Also - look into how to create a .rat-excludes file and include comments > on why filename patterns and directories are excluded. > > Created an issue[4] to track it too. 1. https://github.com/apache/incubator-doris/issues/2032 2. https://github.com/apache/incubator-doris/issues/2029 <https://github.com/apache/incubator-doris/issues/2032> 3. https://github.com/apache/incubator-doris/issues/2030 <https://github.com/apache/incubator-doris/issues/2032> 4. https://github.com/apache/incubator-doris/issues/2031 Thanks, Zhao Chun > Regards, > Dave > > > > > == File: apache-doris-0.11.0-incubating-src/.gitattributes > > == File: apache-doris-0.11.0-incubating-src/be/src/common/status.cpp > > == File: apache-doris-0.11.0-incubating-src/be/src/common/status.h > > == File: apache-doris-0.11.0-incubating-src/be/src/env/env.h > > == File: apache-doris-0.11.0-incubating-src/be/src/env/env_posix.cpp > > == File: apache-doris-0.11.0-incubating-src/be/src/olap/lru_cache.cpp > > == File: apache-doris-0.11.0-incubating-src/be/src/olap/lru_cache.h > > == File: apache-doris-0.11.0-incubating-src/be/src/olap/new_status.cpp > > == File: apache-doris-0.11.0-incubating-src/be/src/olap/new_status.h > > == File: apache-doris-0.11.0-incubating-src/be/src/olap/skiplist.h > > == File: > apache-doris-0.11.0-incubating-src/be/src/runtime/string_search.hpp > > == File: apache-doris-0.11.0-incubating-src/be/src/util/arena.cpp > > == File: apache-doris-0.11.0-incubating-src/be/src/util/arena.h > > == File: apache-doris-0.11.0-incubating-src/be/src/util/coding.cpp > > == File: apache-doris-0.11.0-incubating-src/be/src/util/coding.h > > == File: apache-doris-0.11.0-incubating-src/be/src/util/murmur_hash3.cpp > > == File: apache-doris-0.11.0-incubating-src/be/src/util/murmur_hash3.h > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/cn/administrator-guide/http-actions/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/cn/sql-reference/sql-statements/Data > Definition/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/cn/sql-reference/sql-statements/Data > Manipulation/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/administrator-guide/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/administrator-guide/http-actions/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/administrator-guide/load-data/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/administrator-guide/operation/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/community/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/extending-doris/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/getting-started/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/installing/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/internal/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-functions/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-functions/aggregate-functions/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-functions/date-time-functions/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-functions/spatial-functions/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-functions/string-functions/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-statements/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-statements/Account > Management/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-statements/Administration/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-statements/Data > Definition/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-statements/Data > Manipulation/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-statements/Data > Types/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/documentation/en/sql-reference/sql-statements/Utility/index.rst > > == File: apache-doris-0.11.0-incubating-src/docs/website/Makefile > > == File: apache-doris-0.11.0-incubating-src/docs/website/source/index.rst > > == File: > apache-doris-0.11.0-incubating-src/docs/website/source/_templates/footer.html > > == File: > apache-doris-0.11.0-incubating-src/fe/src/main/java/org/apache/doris/http/Http > API Reference > > == File: apache-doris-0.11.0-incubating-src/webroot/static/bootstrap.css > > == File: > apache-doris-0.11.0-incubating-src/webroot/static/datatables_bootstrap.css > > == File: apache-doris-0.11.0-incubating-src/webroot/static/jquery.js > > > > ---- > > Reed > > l...@apache.org > > > > 在 2019/10/19 下午12:56，“陈明雨”<morning...@163.com> 写入: > > > > Here is my +1 > > > > I have checked > > > > 1. download release from apache dist > > 2. check incubating in release name > > 3. check signature and hashes > > 4. check DISCLAIMER file > > 5. check LICENSE and NOTICE files > > 6. check all source files have ASF headers > > 7. check there is no binary file > > 8. build successfully in docker environment > > > > And there are 2 places need to be improved: > > 1. the download link of Apache Rat is broken in [1], change it to ` > https://archive.apache.org/dist/creadur/apache-rat-0.12/apache-rat-0.12-bin.tar.gz` > <https://archive.apache.org/dist/creadur/apache-rat-0.12/apache-rat-0.12-bin.tar.gz> > > 2. The docker dev images version should be updated to > `apachedoris/doris-dev:build-env-1.1` in [1] > > > > > > [1]: > https://github.com/apache/incubator-doris/wiki/How-to-verify-Apache-Release > > > > Thanks, > > Mingyu Chen > > -- > > 此致！Best Regards > > 陈明雨 Mingyu Chen > > > > Email: > > chenmin...@apache.org > > > > > > > > At 2019-10-17 17:24:22, "Zhao Chun" <zh...@apache.org> wrote: > >> Hi all, > >> > >> Please review and vote on Apache Doris 0.11.0-incubating-rc01 release. > >> > >> The release candidate has been tagged in GitHub as 0.11.0-rc01, > available > >> here: > >> https://github.com/apache/incubator-doris/releases/tag/0.11.0-rc01 > >> > >> Release Notes are here: > >> https://github.com/apache/incubator-doris/issues/1891 > >> > >> Thanks to everyone who has contributed to this release. > >> > >> The artifacts (source, signature and checksum) corresponding to this > release > >> candidate can be found here: > >> https://dist.apache.org/repos/dist/dev/incubator/doris/0.11.0-rc1/ > >> > >> This has been signed with PGP key 983C9560, corresponding to > >> zh...@apache.org. > >> > >> KEYS file is available here: > >> https://dist.apache.org/repos/dist/dev/incubator/doris/KEYS > >> It is also listed here: > >> https://people.apache.org/keys/committer/zhaoc.asc > >> > >> To verify and build, you can refer to following wiki: > >> > https://github.com/apache/incubator-doris/wiki/How-to-verify-Apache-Release > >> https://wiki.apache.org/incubator/IncubatorReleaseChecklist > >> > >> The vote will be open for at least 72 hours. > >> [ ] +1 Approve the release > >> [ ] +0 No opinion > >> [ ] -1 Do not release this package because ... > >> > >> Thanks, > >> Zhao Chun > >> > >> ---- > >> DISCLAIMER: > >> Apache Doris(incubating) is an effort undergoing incubation at The > Apache > >> Software Foundation (ASF), sponsored by the Apache Incubator. > Incubation is > >> required of all newly accepted projects until a further review indicates > >> that > >> the infrastructure, communications, and decision making process have > >> stabilized > >> in a manner consistent with other successful ASF projects. While > incubation > >> status is not necessarily a reflection of the completeness or stability > of > >> the > >> code, it does indicate that the project has yet to be fully endorsed by > the > >> ASF. > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org > > For additional commands, e-mail: dev-h...@doris.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org > For additional commands, e-mail: dev-h...@doris.apache.org > >
