imay commented on a change in pull request #1798: Optimize the load performance
for large file
URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r323815367
##########
File path: be/src/olap/delta_writer.cpp
##########
@@ -147,26 +155,48 @@ OLAPStatus DeltaWriter::write(Tuple* tuple) {
}
_mem_table->insert(tuple);
+
+ // if memtable is full, add it to the flush queue,
+ // and create a new memtable for incoming data
if (_mem_table->memory_usage() >= config::write_buffer_size) {
- RETURN_NOT_OK(_mem_table->flush(_rowset_writer.get()));
+ if (_flush_status.load() != OLAP_SUCCESS) {
Review comment:
RETURN_NOT_OK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
