kangkaisen commented on a change in pull request #1747: Add check for to_bitmap
function argument
URL: https://github.com/apache/incubator-doris/pull/1747#discussion_r321050410
##########
File path: be/src/exec/base_scanner.cpp
##########
@@ -144,6 +144,14 @@ bool BaseScanner::fill_dest_tuple(const Slice& line,
Tuple* dest_tuple, MemPool*
int dest_index = ctx_idx++;
ExprContext* ctx = _dest_expr_ctx[dest_index];
void* value = ctx->get_value(_src_tuple_row);
+ std::string expr_error = ctx->get_error_msg();
Review comment:
Update.
I also considered this pointer yesterday, but I found not all UDF return
value is null when it set error msg to FunctionContext, but we could make all
UDF used in data load follow
this convention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
