imay commented on a change in pull request #1747: Add check for to_bitmap
function argument
URL: https://github.com/apache/incubator-doris/pull/1747#discussion_r320787795
##########
File path: be/src/exec/base_scanner.cpp
##########
@@ -144,6 +144,14 @@ bool BaseScanner::fill_dest_tuple(const Slice& line,
Tuple* dest_tuple, MemPool*
int dest_index = ctx_idx++;
ExprContext* ctx = _dest_expr_ctx[dest_index];
void* value = ctx->get_value(_src_tuple_row);
+ std::string expr_error = ctx->get_error_msg();
Review comment:
Can we do this when value == nullptr? In this way, we can avoid doing this
check in most cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
