imay commented on a change in pull request #1738: add bloom filter index
URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r320569013
##########
File path: be/src/olap/types.h
##########
@@ -74,6 +74,7 @@ class TypeInfo {
inline void set_to_min(void* buf) const { _set_to_min(buf); }
inline uint32_t hash_code(const void* data, uint32_t seed) const { return
_hash_code(data, seed); }
+ inline uint64_t hash_code64(const void* data, uint64_t seed) const {
return _hash_code64(data, seed); }
Review comment:
why do we need hash64?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]