kangkaisen commented on a change in pull request #1613: Refactor alter job
process
URL: https://github.com/apache/incubator-doris/pull/1613#discussion_r312042719
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -143,14 +139,15 @@ private void processDropColumn(DropColumnClause
alterClause, OlapTable olapTable
String targetIndexName = alterClause.getRollupName();
checkIndexExists(olapTable, targetIndexName);
- Column dropColumn = olapTable.getColumn(dropColName);
- if (dropColumn != null && dropColumn.isKey()) {
- checkKeyModificationIfInRandomDistributedTable(olapTable);
- }
-
String baseIndexName = olapTable.getName();
checkAssignedTargetIndexName(baseIndexName, targetIndexName);
+ /*
+ * UNIQUE:
+ * Can not drop any key column.
+ * AGGREGATION:
+ * Can not drp any key column is has value with REPLACE method
Review comment:
```suggestion
* Can not drop any key column which value has REPLACE method
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
