kangpinghuang commented on a change in pull request #505: Change reference to
pointer in task
URL: https://github.com/apache/incubator-doris/pull/505#discussion_r245617629
##########
File path: be/src/olap/task/engine_clone_task.h
##########
@@ -29,10 +33,14 @@ namespace doris {
class EngineCloneTask : public EngineTask {
public:
- virtual AgentStatus execute();
+ virtual OLAPStatus execute();
public:
- EngineCloneTask(TCloneReq& _clone_req, vector<string>& error_msgs,
vector<TTabletInfo> tablet_infos);
+ EngineCloneTask(const TCloneReq& _clone_req, vector<string>* error_msgs,
+ vector<TTabletInfo>* tablet_infos,
+ AgentStatus* _res_status,
+ int64_t _signature,
+ const TMasterInfo& _master_info);
Review comment:
move input arguments before output arguments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
