mbeckerle commented on a change in pull request #264: WIP - DAFFODIL-2169
URL: https://github.com/apache/incubator-daffodil/pull/264#discussion_r306839470
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetImpl.scala
##########
@@ -95,6 +96,10 @@ sealed trait DINode {
}
+object DINode{
+ implicit def toDINode(v: DataValueDINodeTrait):DINode =
v.asInstanceOf[DINode]
Review comment:
This cast is only needed because of the daffodil-lib location of the
DataValue class. This whole thing can be mixins to DINode and then there's no
casting I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
