reta commented on code in PR #2999:
URL: https://github.com/apache/cxf/pull/2999#discussion_r3003762566
##########
systests/tracing/src/test/java/org/apache/cxf/systest/brave/jaxrs/AbstractBraveTracingTest.java:
##########
@@ -265,9 +265,10 @@ public void testThatProvidedSpanIsNotClosedWhenActive()
throws MalformedURLExcep
}
// Await till flush happens, usually a second is enough
- await().atMost(Duration.ofSeconds(5L)).until(()->
TestSpanHandler.getAllSpans().size() == 4);
+ await().atMost(Duration.ofSeconds(5L)).untilAsserted(() -> assertThat(
Review Comment:
Thanks @gnodet , I think this is valuable improvement, do you think we could
extract custom `Matcher` (for example, `HasSize` but for
`Collection<MutableSpan>`) out of it to have something like:
```
await().atMost(Duration.ofSeconds(5L)).untilAsserted(() ->
assertThat(TestSpanHandler.getAllSpans(), hasSize(4)));
```
I could happily help with that, it will reduce the amount of duplication in
assertions, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
