ottlinger commented on code in PR #268:
URL: https://github.com/apache/creadur-rat/pull/268#discussion_r1667451477
##########
apache-rat-core/src/main/java/org/apache/rat/OptionCollection.java:
##########
@@ -581,7 +560,7 @@ static Optional<IOFileFilter> parseExclusions(final Log
log, final List<String>
if (ignoredLines > 0) {
log.info("Ignored " + ignoredLines + " lines in your exclusion
files as comments or empty lines.");
}
- return orFilter.getFileFilters().isEmpty() ? Optional.empty() :
Optional.of(orFilter);
+ return orFilter.getFileFilters().isEmpty() ? Optional.empty() :
Optional.of(new NotFileFilter(orFilter));
Review Comment:
Somehow this line is odd to read .....
OrFilter does not look similar to NotFileFilter to me.
Has there been a semantic change in newer apache-commons-versions? or should
the variable be renamed to notFileFilter here?
Or does the change invert the logics of the CLI option (then we should add a
big note to the webpage ;))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
