I responded on the PR: while I agree the PR fixes a few cases, there are more issues in this part of the codebase.
Earlier[0], I changed UriParser.normalisePath to support URI-encoded characters, as that seemed like the least invasive change to fix the particular issue I was dealing with back then. However, looking closer at the code now, I see more places that would need to be updated to support those reliably. I now think we should simplify the code by converting those URI-encoded characters already in UriParser.fixSeparators, instead of trying to support them later on. This has a somewhat larger risk of changing behaviour and breaking existing code, but reduces the risk of remaining bugs in this area. I tried this out quickly in [1] and the (fairly extensive) set of unit tests accepts it. Arnout [0]: https://github.com/apache/commons-vfs/pull/396 [1]: https://github.com/apache/commons-vfs/pull/555 On Sun, Jun 16, 2024 at 1:39 PM Gary Gregory <garydgreg...@gmail.com> wrote: > Hi All, > > PR https://github.com/apache/commons-vfs/pull/543/files claims to > resolve 2 issues. > > I want feedback from this list, please. > > TY! > Gary > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- Arnout Engelen ASF Security Response Apache Pekko PMC member, ASF Member NixOS Committer Independent Open Source consultant
