+1 TODO later: Update RNs since the POM uses version "1.2.0" and the release notes use "1.2".
TODO later: src\native\windows\README should have a file extension since on Windows text files without extensions are not customary. TODO later: Fix Javadocs for Java 11 with 'mvn -V clean install site' [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project commons-daemon: Error generating maven-javadoc-plugin:3.1.0:javadoc report: [ERROR] Exit code: 1 - C:\temp\rc\commons-daemon\src\main\java\org\apache\commons\daemon\DaemonPermission.java:38: error: attribute not supported in HTML5: width [ERROR] * <table width="100%" border="1"> Java 8 OK with: - 'mvn apache-rat:check', - 'mvn clirr:check'. - 'mvn -V clean install site', Java 11 OK with 'mvn -V clean install' I was able to run 'nmake CPU=X86' (NMake Version 14.21.27702.2) on Windows 10.0.16299.1087 for both Windows apps. There is no 'SetEnv' script in my VS install so 'nmake CPU=X64' failed. Our README needs a bit of updating. Did you use the antique versions mentioned in the README? If not, please update the file for future reference. Java versions mentioned above: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-11.0.3 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_212\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On Fri, Jun 28, 2019 at 10:21 AM Mark Thomas <ma...@apache.org> wrote: > It has been ~18 months since the last Commons Daemon release. After the > recent flurry of activity and a couple of failed RCs, it is time for > another release vote. > > Notable changes since 1.1.0 include: > - Improved JRE/JDK detection to support increased range of both JVM > versions and vendors. > - Procrun. Minimum target platform for Windows binaries is now Windows 7 > - Procrun. Change the default service from LocalSystem to > 'NT Authority\LocalService' > > The full set of changes is in the changelog > > 1.2.0 RC2 can be obtained from (r34680): > https://dist.apache.org/repos/dist/dev/commons/daemon/ > > The git tag is: > Tag: COMMONS_DAEMON_1_2_0_RC2 > URL: > > https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=d88fd9100c1110fa51b7c7a08e3e7efd0e58227b > Hash: d88fd9100c1110fa51b7c7a08e3e7efd0e58227b > > The Maven Staging repo is: > https://repository.apache.org/content/repositories/orgapachecommons-1443/ > > The Windows binaries have been signed by the Symantec code signing service. > > Files signed with my preferred key: > http://people.apache.org/~markt/ > KEYS file is standard Apache Commons keys file: > http://www.apache.org/dist/commons/KEYS > > > [ ] Approved - go ahead and release Commons Daemon 1.2.0 RC2 as 1.2.0 > [ ] Broken - do not release because... > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
