On Fri, May 19, 2017 at 1:49 PM, Benedikt Ritter <brit...@apache.org> wrote:
> Hello Gary, > > > Am 18.05.2017 um 17:00 schrieb Gary Gregory <garydgreg...@gmail.com>: > > > > Since the current version of maven-site-plugin is 3.6, it would be nice > to > > note what happens for that version as well. > > I was just removing trailing white spaces and don’t know what you’re > talking about :o) > Hi, I just read the comments about 3.5.1 in the commit email; my comment was not directed at your commit specifically. I apologize for the confusion, I should have posted under a separate Subject. Gary > > Benedikt > > > > > Gary > > > > On Thu, May 18, 2017 at 12:04 PM, <brit...@apache.org> wrote: > > > >> Author: britter > >> Date: Thu May 18 19:04:38 2017 > >> New Revision: 1795551 > >> > >> URL: http://svn.apache.org/viewvc?rev=1795551&view=rev > >> Log: > >> Remove trailing white spaces > >> > >> Modified: > >> commons/proper/commons-parent/trunk/pom.xml > >> > >> Modified: commons/proper/commons-parent/trunk/pom.xml > >> URL: http://svn.apache.org/viewvc/commons/proper/commons-parent/ > >> trunk/pom.xml?rev=1795551&r1=1795550&r2=1795551&view=diff > >> ============================================================ > >> ================== > >> --- commons/proper/commons-parent/trunk/pom.xml (original) > >> +++ commons/proper/commons-parent/trunk/pom.xml Thu May 18 19:04:38 > 2017 > >> @@ -43,7 +43,7 @@ Version 43: > >> Version 42: > >> > >> - maven-changes-plugin 2.12 -> 2.12.1 > >> -- maven-site-plugin 3.4 -> 3.6 (for migrating from 3.4 to 3.5.1, see > >> https://maven.apache.org/components/plugins/maven-site- > plugin/migrate.html > >> ) > >> +- maven-site-plugin 3.4 -> 3.6 (for migrating from 3.4 to 3.5.1, see > >> https://maven.apache.org/components/plugins/maven-site- > plugin/migrate.html > >> ) > >> - jacoco-maven-plugin : 0.7.6.201602180812 -> 0.7.7.201606060606 > >> - commons-build-plugin : 1.6 -> 1.7 > >> - maven-changes-plugin : 2.12 -> 2.12.1 > >> @@ -611,7 +611,7 @@ Version 39: > >> <configuration> > >> <!-- > >> commons.surefire.java is normally empty. > >> - It is defined by the java-1.x profiles to change the JVM > used > >> by Surefire > >> + It is defined by the java-1.x profiles to change the JVM > used > >> by Surefire > >> --> > >> <jvm>${commons.surefire.java}</jvm> > >> </configuration> > >> @@ -878,7 +878,7 @@ Version 39: > >> <!-- > >> This property should always be defined. > >> The intention is to ensure that the profile is always > >> enabled. > >> - (activeByDefault only applies if other profiles are not > >> enabled) > >> + (activeByDefault only applies if other profiles are not > >> enabled) > >> --> > >> <name>user.home</name> > >> </property> > >> @@ -906,10 +906,10 @@ Version 39: > >> </build> > >> </profile> > >> > >> - <!-- > >> + <!-- > >> Runs the Animal Sniffer plugin to check that generated code > >> does not included references > >> to methods/classes etc that are not present in the standard > >> Java runtime for the defined target version. > >> - To bypass the checks, define "animal.sniffer.skip" as true, > or > >> create the file "src/site/resources/profile.noanimal" > >> + To bypass the checks, define "animal.sniffer.skip" as true, > or > >> create the file "src/site/resources/profile.noanimal" > >> --> > >> > >> <profile> > >> @@ -920,7 +920,7 @@ Version 39: > >> <missing>src/site/resources/profile.noanimal</missing> > >> </file> > >> </activation> > >> - > >> + > >> <properties> > >> <!-- define this as a property to allow command-line override > >> --> > >> <animal-sniffer.signature>java${javaTarget.majorVersion} > >> ${javaTarget.minorVersion}</animal-sniffer.signature> > >> @@ -939,7 +939,7 @@ Version 39: > >> <id>checkAPIcompatibility</id> > >> <!-- default is: <phase>process-classes</phase> --> > >> <!-- Note: if the plugin is ever enhanced to check > test > >> classes > >> - it will presumably need to be bound to > >> process-test-classes instead > >> + it will presumably need to be bound to > >> process-test-classes instead > >> --> > >> <goals> > >> <goal>check</goal> > >> @@ -1512,13 +1512,13 @@ Version 39: > >> > >> <!-- Default configuration for compiler source and target JVM --> > >> <!-- Do NOT change this; it must remain as 1.3 --> > >> - <!-- > >> + <!-- > >> It's important that child POMs don't need to change when the > >> parent POM is updated. > >> At the time when these properties were introduced, the default > >> Java version was 1.3. > >> Thus components that failed to define the version would not be > >> affected by updates > >> to the Commons Parent or its parent the Apache pom. > >> Of course most if not all components now define the properties. > >> - However it's still important to keep the properties as they > >> effectively > >> + However it's still important to keep the properties as they > >> effectively > >> force child poms to define the Java version they require. > >> --> > >> <maven.compiler.source>1.3</maven.compiler.source> > >> @@ -1542,21 +1542,21 @@ Version 39: > >> <commons.jxr.version>2.5</commons.jxr.version> > >> <commons.project-info.version>2.9</commons.project-info.version> > >> <commons.wagon-ssh.version>2.10</commons.wagon-ssh.version> > >> - <!-- > >> + <!-- > >> Note: Maven site plugin 3.5.1 is the latest version but is not a > >> direct replacement: > >> > >> http://maven.apache.org/plugins/maven-site-plugin/migrate.html > >> > >> In particular, adding CDATA to header and footer sections is not > >> backwards compatible. > >> - I.e. these have to be updated at the same time. > >> + I.e. these have to be updated at the same time. > >> > >> Also it causes the following errors: > >> > >> - [ERROR] Failed to execute goal org.apache.maven.plugins: > maven-site-plugin:3.5.1:site > >> (default-site) on project commons-parent: > >> - Execution default-site of goal org.apache.maven.plugins: > maven-site-plugin:3.5.1:site > >> failed: > >> + [ERROR] Failed to execute goal org.apache.maven.plugins: > maven-site-plugin:3.5.1:site > >> (default-site) on project commons-parent: > >> + Execution default-site of goal org.apache.maven.plugins: > maven-site-plugin:3.5.1:site > >> failed: > >> A required class was missing while executing > org.apache.maven.plugins:maven-site-plugin:3.5.1:site: > >> org/apache/maven/doxia/sink/impl/XhtmlBaseSink > >> > >> - This is because Apache POM 17 forces an older version of Doxia > core: > >> + This is because Apache POM 17 forces an older version of Doxia > core: > >> https://mail-archives.apache.org/mod_mbox/maven-users/ > >> 201602.mbox/%3C2337255.xU7aS9G1qr@herve-desktop%3E > >> > >> The same error applies when running with version 3.5. > >> @@ -1683,7 +1683,7 @@ Version 39: > >> <!-- allow japicmp's breakBuildOnBinaryIncompatibleModifications > >> to be overridden, plugin's default is false --> > >> <commons.japicmp.breakBuildOnBinaryIncompatible > >> Modifications>true</commons.japicmp.breakBuildOnBinaryIncompatible > >> Modifications> > >> - > >> + > >> <sonar.host.url>https://analysis.apache.org/</sonar.host.url> > >> > >> </properties> > >> > >> > >> > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second Edition > > <https://www.amazon.com/gp/product/1617290459/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459& > linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1617290459> > > JUnit in Action, Second Edition > > <https://www.amazon.com/gp/product/1935182021/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021& > linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22 > > > > > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1935182021> > > Spring Batch in Action > > <https://www.amazon.com/gp/product/1935182951/ref=as_li_ > tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951& > linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B% > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> > > <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a= > 1935182951> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
