On Wed, Jun 29, 2016 at 10:06 PM, Benedikt Ritter <brit...@apache.org> wrote:
> JNA should ne removed again in order to push out an initial release! We're > again in the "lets make this perfect" mode, delaying the release with stuff > that has been discussed to be targeted for 1.x > The update to Java 7 is another example for this. > I would be OK to move JNA to a branch if it is not too much work (and someone wants to do it) but I think the benefit of having done the work is to help make sure we have a stable API for 1.0. It would be a shame to have to do a BC breaking release later to accommodate JNA. I do not see the move to Java 7 as an unnecessary step, I think it helps make the code base better. It seems normal that a 1.0 release is more work than any other 1.x just because you DO want to make sure the API is right, and that's work. After 1.0, you do not have to worry about the API, it is set for 1.x. Then for a 2.0 or any major release, you can dig in for more "make it perfect" work ;-) Gary > > Benedikt > > sebb <seb...@gmail.com> schrieb am Do., 30. Juni 2016 um 02:15: > > > On 30 June 2016 at 01:06, Gary Gregory <garydgreg...@gmail.com> wrote: > > > On Wed, Jun 29, 2016 at 5:06 PM, Gary Gregory <garydgreg...@gmail.com> > > > wrote: > > > > > >> Now that we have the JNA backstop, some tests fail on Windows. It > would > > be > > >> nice to be able to run ALL the tests with and without JNA. > > >> > > > > > > For example: > > > > > > org.junit.ComparisonFailure: > > > expected:<...mmons.crypto.cipher.[Openssl]Cipher> but > > > was:<...mmons.crypto.cipher.[Jce]Cipher> > > > > This is nothing to do with JNA. > > > > It's because the Cipher factory defaults to OpensslCipher,JceCipher > > > > Since Windows does not support OpenSSL yet, the factory uses Jce. > > > > > > > at org.junit.Assert.assertEquals(Assert.java:115) > > > at org.junit.Assert.assertEquals(Assert.java:144) > > > at > > > > > > org.apache.commons.crypto.cipher.CryptoCipherFactoryTest.testDefaultCipher(CryptoCipherFactoryTest.java:33) > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > > at > > > > > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > > > at > > > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > > at java.lang.reflect.Method.invoke(Method.java:606) > > > at > > > > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > > > at > > > > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > > > at > > > > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > > > at > > > > > > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > > > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > > > at > > > > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > > > at > > > > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > > > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > > > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > > > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > > > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > > > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > > > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > > > at > > > > > > org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86) > > > at > > > > > > org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) > > > at > > > > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459) > > > at > > > > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678) > > > at > > > > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382) > > > at > > > > > > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192) > > > > > > G > > > > > >> > > >> Gary > > >> > > >> -- > > >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > >> Java Persistence with Hibernate, Second Edition > > >> <http://www.manning.com/bauer3/> > > >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > >> Spring Batch in Action <http://www.manning.com/templier/> > > >> Blog: http://garygregory.wordpress.com > > >> Home: http://garygregory.com/ > > >> Tweet! http://twitter.com/GaryGregory > > >> > > > > > > > > > > > > -- > > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > > Java Persistence with Hibernate, Second Edition > > > <http://www.manning.com/bauer3/> > > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > > Spring Batch in Action <http://www.manning.com/templier/> > > > Blog: http://garygregory.wordpress.com > > > Home: http://garygregory.com/ > > > Tweet! http://twitter.com/GaryGregory > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
