Hello Bernd, I am sorry for the delay in replying to you.
The best input to any Commons project is to create a Jira and attach a patch in diff file format. As for our process, Github is fun but we only use it as a mirror and it just makes it harder to merge changes back in SVN. So I am not sure why we do that in the first place instead of switching the project to Git, but that's a different story. Gary On Wed, Sep 25, 2013 at 7:57 PM, Bernd Eckenfels <e...@zusammenkunft.net>wrote: > Hello, > > I rebased Pull#1 against trunk and made a fixup of the commits into one. > > https://github.com/apache/**commons-vfs/pull/1<https://github.com/apache/commons-vfs/pull/1> > > Do I need to file it on Jira? > > Greetings > Bernd > > Am 18.09.2013, 22:00 Uhr, schrieb Bernd Eckenfels <e...@zusammenkunft.net > >: > > all over the VFS core and providers there are many places where code is >> commented out. Most of the time it looks like it is old code, but sometimes >> it also looks like suggested new implementations or even TODO style of >> things. >> >> I started to remove some of the places, especially where it looks obvious >> to me that it is simply commented out code variantes of older versions. >> Also some other minor comment related stuff is in this pull request here: >> >> https://github.com/apache/**commons-vfs/pull/1<https://github.com/apache/commons-vfs/pull/1> >> >> Can you check out and see if you think I removed too much or not enough? >> I did not reviewed all files systematically it is more like the files I >> happen to look at anyway. >> > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: > dev-unsubscribe@commons.**apache.org<dev-unsubscr...@commons.apache.org> > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
