So do I for the Struts stuff. Sent from my mobile device, so please excuse typos and brevity.
Maurizio Cucchiara Il giorno 09/ott/2011 22.07, "Simone Tripodi" <simonetrip...@apache.org> ha scritto: > Hi Christian! > Agreed. Being myself part of the MyBatis community, I can take care of > testing the purged commons OGNL. > Have a nice day, all the best! > Simo > > http://people.apache.org/~simonetripodi/ > http://www.99soft.org/ > > > > On Sun, Oct 9, 2011 at 6:23 PM, Christian Grobmeier <grobme...@gmail.com> > wrote: > > Hi > > > >> I'm honestly skeptical on removing stuff, no one knows who's using > >> that methods - I should to take care about checking on MyBatis code, > >> AFAIK Struts uses some of them... > >> What about increasing tests instead dropping stuff? They should be > >> method provided for 3rd party clients... > > > > The proposed methods are from SimpleNode (which is used by AST* > > classes) and OgnlRuntime (not sure if these can deleted safely). I > > would say, if MyBatis / Struts etc would sue SimpleNode... then they > > have a huge problem. At least this is my understanding of the issue. > > > > If we choose to increase test cases, then we need to fix some stuff: > > Daniel already found some bugs in the methods. I have looked briefly > > over all, I could not identify the sense of some of them. So I guess > > it will be pretty difficult to say if somebody should/could use these > > methods at all. > > > > A major bumb of the version number might be a good chance to get rid > > of the dirt, ohterwise we'll stick with it for another long period. > > > > Probably we should make a good bunch of tests with MyBatis/Struts and > > a pre-release to make sure the biggest OGNL customers are still > > running with it? > > > > Wdyt? > > > >> TIA! > >> Simo > >> > >> http://people.apache.org/~simonetripodi/ > >> http://www.99soft.org/ > >> > >> > >> > >> On Sun, Oct 9, 2011 at 3:56 PM, Christian Grobmeier < > grobme...@gmail.com> wrote: > >>> Hi, > >>> > >>> the code patch on ognl-21 does remove some public methods on > >>> OgnlRuntime and SimpleNode. I don't think folks are usually caring on > >>> those two classes, but how do we proceed with backwards compatility? > >>> > >>> Daniel has remove a bunch of methods, which really look a bit outdated > >>> or unused. As we are working on a major version and already have > >>> package changes, we might agree on removing the methods. > >>> > >>> I have already added the patch to my local system, if you are fine > >>> with it too, i will apply it. > >>> > >>> Wdyt? > >>> > >>> Cheers > >>> Christian > >>> > >>> > >>> -- > >>> http://www.grobmeier.de > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > > > -- > > http://www.grobmeier.de > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
