Ralph Goers wrote: > From my narrow perspective I don't really think it is necessary. > However, I just went and looked at some of the configurations and > noticed that one of the enhancements I made to 2.1 is not reflected in > trunk. I thought I had made the corresponding changes there but maybe I > didn't since at the time I had no way of testing anything. > > I changed all the items that would likely need to be tunable to be > parameterized. For example, the pool size for most generators is > hard-coded at 16. This is a PITA to modify when it is coming from > Cocoon core. These values should all be parameterized like they are in > 2.1. I see that the store sizes have been set up to do this, but > everything in 2.1's src/webapp/WEB-INF/properties/core.properties needs > to also be reflected in trunk, unless they no longer apply. I agree, we should use the same properties from 2.1.x in 2.2 where they apply. For spring managed beans, we don't need properties anymore, we can use the override mechanism, making configuration much easier as you don't have to use properties all over the place. (See Spring documentation for property override for more informatione)
> > Speaking of pooling, (well, we weren't really, but I don't want to start > another email) I thought we were going to replace the pooled generators, > etc. with a factory. What ever happened with that? I thought there was > a FileGenerator version of that but I don't see it now. > I removed the factory :) as it is not needed anymore. We use Spring as the factory and spring generates new FileGenerators for us. So the FileGenerator from trunk is a spring managed bean and not an avalon component anymore. Carsten -- Carsten Ziegeler - Chief Architect http://www.s-und-n.de http://www.osoco.org/weblogs/rael/
