[
http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427267
]
Antonio Gallardo commented on COCOON-1758:
------------------------------------------
Thanks for the feedback Simone. You are fully right. I reviewed the Carlos
patch against the repository and is not the same. I recall I did some tests
before committing to checking if this is working as expected. After testing,
for some reason I forgot to revert my test changes. In short:
I bad commit was:
cocoon.parameters.getParameter('locale')
and patch reads:
cocoon.parameters.getParameter('locale','')
(please note the "empty" string as default value.
I am going to commit the "fix to the fix", right now. :-)
Thanks again for spotting the issue.
> Form locale never used in JXMacros
> ----------------------------------
>
> Key: COCOON-1758
> URL: http://issues.apache.org/jira/browse/COCOON-1758
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9
> Reporter: Philippe Gassmann
> Assigned To: Antonio Gallardo
> Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
>
> Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt
>
>
> The JXMacroHelper is created with : <jx:set var="cformsHelper"
> value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/>
> So the locale is get from sitemap parameters.
> the locale attribute of the form is then never used.
> I will provide a patch as soon as possible
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
