On Mon, 2004-04-05 at 13:38, Guido Casper wrote:
Rolf Kulemann wrote:
[Related to http://issues.apache.org/bugzilla/show_bug.cgi?id=28189]
<quote src="Guido Capser">
As for WebDAVRepsoitoryVersioningHelper.setVersioned(): I don't think it
is a good idea to throw an UnsupportedOperationException only under certain conditions.
</quote>
Agreed.
Maybe it makes sense to split setVersioned(String, boolean) into two methods
1.) setVersioned(String) 2.) unsetVersioned(String)
in order to be more flexible in the implementation decisions?
Why should that be more flexible?
Because I can decide if I implement both or only one method. The reason for the split is, I can use the NotSupportedException more accurate.
Well, throwing UnsupportedOperationException is not my final goal for either :-)
I guess having too many of those might indicate an unappropriate interface.
TBH I'm not so sure wether these should be part of the Repository interface at all as it looks like being geared towards WebDAV only (but I don't know right now).
Ok, I didn't mean the Repsoitory interface, was a litlle bit confusing maybe, but the RepositoryVersioningHelper. And if a repository does not support versioning it has no helper at all.
Yes, but I was talking about the RepositoryVersioningHelper as well (a single repository having both versioned and non-versioned resources) which is exactly the point of my comment above.
I think it might be a wise move to first gather experiences with other implementations (instead of adding more operations coming directly from a WebDAV context).
Guido
--
Guido Casper
-------------------------------------------------
S&N AG, Competence Center Open Source
Tel.: +49-5251-1581-87
Klingenderstr. 5 mailto:[EMAIL PROTECTED]
D-33100 Paderborn http://www.s-und-n.de
-------------------------------------------------
