GitHub user ChaosEternal added a comment to the discussion: [Ideas] Submodule Pinning
Hi Dianjin, If we care about eye friendly, as I suggested, we can put the branch or tag in the comment of the .gitmodules file and in the commit message. For checking, it is very hard to find out if an upstream has some updated tags(impossible for human eyes). What we need to do is to have a CI task to check that, and having commit SHA is much easier for scripts. On Wed, May 7, 2025 at 2:37 PM Dianjin Wang ***@***.***> wrote: > Hey @ChaosEternal <https://github.com/ChaosEternal> when reviewing the > PR, I found it hard to compare the commit SHA with the corresponding > branch, which will not be friendly for future review and maintenance. When > referring to the main/master branch in the .gitmodules file, I saw that > the latest commit SHA has changed for most projects. > > Here is my proposal for this: > > - If the projects have tags, we can use the tags as a mark to have an > eye-friendly view, and if needed, can add the commit SHA and commit date as > a comment for tag tracking to prevent the tags from being forced removed in > the upstream projects. > - If the projects have no tags with only the main branch, we can > specify one commit in the main branch as the mark, and can add the commit > date as a comment for note. > > For the concern on upstream projects, I think if the upstream projects > have been removed or shut down, then we need to seek an active alternative > to them, but for now, at the very lowest possibility. So let's get started > with an easy way to proceed. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/cloudberry/discussions/1083#discussioncomment-13058481>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALMFGYFJVL2PVOCDFHKRYL25GEX7AVCNFSM6AAAAAB4LE4DLKVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTGMBVHA2DQMI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > GitHub link: https://github.com/apache/cloudberry/discussions/1083#discussioncomment-13058631 ---- This is an automatically sent email for dev@cloudberry.apache.org. To unsubscribe, please send an email to: dev-unsubscr...@cloudberry.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cloudberry.apache.org For additional commands, e-mail: dev-h...@cloudberry.apache.org
