Awesome, thanks for the update! I’ll check it out. -=e
On Wed, Nov 27, 2024 at 7:31 PM Hao Wu <gfphoeni...@gmail.com> wrote: > Hi Ed, > I've opened a PR(https://github.com/apache/cloudberry/pull/736) to fix > the pipeline failure. It passes these tests in my local environment. It > should also work in our pipeline. > Please let me know if anything is wrong. > > Thanks > Hao Wu > > On Wed, Nov 27, 2024 at 11:06 AM Ed Espino <esp...@apache.org> wrote: > >> Hi Wu Hao, >> >> Thank you for your response. While you review addressing the test issue, I >> will open a parallel PR to enable more test suites to be run for PRs and >> main merges. >> >> Thanks, >> -=e (艾德) >> >> On Tue, Nov 26, 2024 at 6:37 PM Hao Wu <gfphoeni...@gmail.com> wrote: >> >> > Thanks for your feedback, Ed. I'll take a look. >> > >> > On Wed, Nov 27, 2024 at 5:58 AM Ed Espino <esp...@apache.org> wrote: >> > >> > > Hey folks, >> > > >> > > While working on re-enabling tests in our new Apache workflow (tests >> > that I >> > > had previously disabled), I noticed that ic_singlenode_regress tests >> are >> > > failing following the changes made in PR #695 ("Make gp-style >> partition >> > > table compatible with greenplum" >> > > https://github.com/apache/cloudberry/pull/695). >> > > >> > > I'm sharing this on the dev list in the spirit of open collaboration - >> > this >> > > kind of follow-up work is a normal part of our development process as >> we >> > > evolve the codebase together. As I'm the one who disabled these tests >> > > initially, it feels right to highlight what I'm finding as I work to >> > bring >> > > them back online. >> > > >> > > The failures can be reproduced in a single-node setup using:| >> > > >> > > cd <cloudberry src directory> >> > > NUM_PRIMARY_MIRROR_PAIRS=0 make create-demo-cluster >> > > make installcheck-singlenode --directory=src/test/singlenode_regress >> > > >> > > For those interested, you can see my development Cloudberry workflow >> in >> > > action (with the test issue): >> > > >> > > https://github.com/edespino/cloudberry/actions/runs/12037000664 >> > > >> > > It appears the test expectations need to be updated to align with the >> new >> > > GP-style partition table compatibility changes. >> > > >> > > Best regards, >> > > -=e >> > > -- >> > > Ed Espino >> > > Apache Cloudberry (incubating) & MADlib >> > > >> > >> >> >> -- >> Ed Espino >> Apache Cloudberry (incubating) & MADlib >> >
