Re: [DISCUSS] Bracing style on trunk

[Benedict]

This is a mad idea that I can’t believe anyone is seriously entertaining. -1. On 18 Jan 2025, at 13:17, Josh McKenzie <jmcken...@apache.org> wrote:  Trying to break out discussions here to keep things moving - see thread "Checkstyle as style contract for Cassandra" One topic that came up on the thread was whether we were collectively happy with our current newline bracing style and, if not, what we might do about it. The following points came up: We would do this post-accord merging so as not to cause significant rebase pains for the branch (unless active accord devs advocate for otherwise) re: git history pollution, Abe pointed out that we can use a --ignore-revs-file option in git to switch bracing style in one go and keep our history. Caleb advocated for limiting ourselves to trunk only. Given only bugfixes go to older branches this would limit our surface area of change quite a bit. Mick seconded raised concerns about forks absorbing pain. We have multiple fork owners on the thread in favor of making the change, but it's worth keeping in mind. In general, sentiment was clearly skewed towards changing our bracing style on trunk to have braces on the same line as preceding control flow statement, closing braces on newline.