So, was reviewing SAI and found we convert ipv4 to ipv6 (which is valid for the type) and made me wonder what the behavior would be if client mixed ipv4 with ipv4 encoded as ipv6… this caused me to find a different behavior in SAI to the rest of C*… where I feel C* is doing the wrong thing…
Lets walk over a simple example ipv4: 127.0.0.1 ipv6: 0:0:0:0:0:ffff:7f00:0001 Both of these address are equal according to networking and java… but for C* they are different! These are 2 different values as ipv4 is 4 bytes and ipv6 is 16 bytes, so 4 != 16! With SAI we convert all ipv4 to ipv6 so that the search logic is correct… this causes SAI to return partitions that ALLOW FILTERING and other indexes wouldn’t… This gets to the question in the subject… what SHOULD we do for this type? I see 3 options: 1) SAI use the custom C* semantics where 4 != 16… this keeps us consistent… 2) ALLOW FILTERING and other indexes are “fixed” so that we actually match correctly… we are not really able to fix if the type is in a partition or clustering column though… 3) deprecate inet in favor of a inet_better type… where inet semantics is the custom C* semantics and inet_better handles this case Thoughts?
