Hi Claude,

while technically possible, I do not see a lot of people would use this. I am 
for straightforward -H option instead of introducing -Hn which seems to bring 
almost no value and brings discrepancy into the nodetool flags. I think there 
are other -H outputs for other commands, are not there? Should not we then also 
take a look if -Hn is not applicable for them as well? Anyway ... this seems to 
be just a lot of work with almost no benefit.

Regards

________________________________________
From: Claude Warren, Jr via dev <dev@cassandra.apache.org>
Sent: Tuesday, December 5, 2023 8:46
To: dev@cassandra.apache.org
Cc: Claude Warren, Jr
Subject: Re: [DISCUSS] CASSANDRA-19104: Standardize tablestats formatting and 
data units

EXTERNAL EMAIL - USE CAUTION when clicking links or attachments



Why not change the option so that -H will operate as it does now while -Hn 
(where n is a digit) will limit the number of decimal places to n.

On Mon, Dec 4, 2023 at 5:11 PM Brad 
<bscho...@gmail.com<mailto:bscho...@gmail.com>> wrote:
Thanks, Jacek.  Using three significant digits for disk space is a good 
suggestion.

On Mon, Dec 4, 2023 at 9:58 AM Jacek Lewandowski 
<lewandowski.ja...@gmail.com<mailto:lewandowski.ja...@gmail.com>> wrote:
This looks great,

I'd consider limiting the number of significant digits to 3 in the human 
readable format. In the above example it would translate to:

Space used (live): 1.46 TiB
Space used (total): 1.46 TiB

Bytes repaired: 0.00 KiB
Bytes unrepaired: 4.31 TiB
Bytes pending repair: 0.000 KiB

I just think with human readable format we just expect to have a grasp view of 
the stats and 4th significant digit has very little meaning in that case.


thanks,
Jacek

Reply via email to