> But it seems to me that we should support enabled=false without removing all
> the other parameters so that users can disable the compression for testing or
> problem resolution without losing an of the other parameter settings.
Yes, I agree with this. Mere "enabled: false" should be just enough.
If this is false, we might default to NoOp compressor.
________________________________________
From: Claude Warren, Jr via dev <dev@cassandra.apache.org>
Sent: Wednesday, April 19, 2023 14:06
To: dev
Subject: [COMPRESSION PARAMETERS] Question
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
Currently the compression parameters has an option called enable. When
enable=false all the other options have to be removed. But it seems to me that
we should support enabled=false without removing all the other parameters so
that users can disable the compression for testing or problem resolution
without losing an of the other parameter settings. So to be clear:
The following is valid:
hints_compression:
- class_name: foo
parameters:
- chunk_length_in_kb : 16 ;
But this is not:
hints_compression:
- class_name: foo
parameters:
- chunk_length_in_kb : 16 ;
enabled : false ;
Currently when enabled is set false is constructs a default CompressionParam
object with the class name set to null.
Is there a reason to keep this or should we accept the parameters and construct
a CompressionParam with the parameters while continuing to set the class name
to null?
Claude
