> By submitting this pull request, I acknowledge that I am making a > contribution to the Apache Software Foundation under the terms and conditions > of the [Contributor's > Agreement](https://www.apache.org/licenses/contributor-agreements.html).
Do we expect every contributor who makes any contribution to agree to this? If we don’t, does it imply anything weird to start stipulating this for PRs only? Might be worth running past legal, as we don’t expect ICLAs to be signed for many contributions today, nor any specific assignment besides the notice at the top of any files in the contribution. I’m also not convinced we should be doing much more than letting the user know they should have read and followed the style guide and contribution guide, and that before being merged a commit should include documentation and test changes - but these aren’t probably blockers for an initial review, and might discourage contributions by making the initial hurdles appear higher. > On 16 Aug 2022, at 09:01, Claude Warren, Jr via dev > <dev@cassandra.apache.org> wrote: > > > I am all for simplification. How about > > ----- start of text ---- > > Issue resolved: CASSANDRA- > > ---- > - [ ] Jira ticket contains a description of: what is fixed, why it is > needed, and what branches to apply it to. > - [ ] Commits have been squashed to remove intermediate development commit > messages. > - [ ] Key commit messages start with the issue number (CASSANDRA-xxxx) > > either > - [ ] this is a trivial documentation change. (e.g. fixes a typo) > or: > - [ ] Tests are included. > - [ ] Documentation changes and/or updates are included. > > > By submitting this pull request, I acknowledge that I am making a > contribution to the Apache Software Foundation under the terms and conditions > of the [Contributor's > Agreement](https://www.apache.org/licenses/contributor-agreements.html). > > See the [Apache Cassandra "Contributing to Cassandra" > guide](https://cassandra.apache.org/_/development/index.html) and/or the > [Apache Cassandra "Working on Documentation" > guide](https://cassandra.apache.org/_/development/documentation.html) > > > ---- end of text ---- > >> On Tue, Aug 16, 2022 at 8:42 AM Erick Ramirez <erickramire...@apache.org> >> wrote: >> +1 this is a great idea. But personally, I'm not too fussed about the level >> of detail that is in the template -- what is important is that contributors >> are reminded that there needs to be a ticket associated with contributions. >> Without being too prescriptive, aspiring contributors should really >> familiarise themselves with how to contribute[1] so they would know to >> search existing tickets first to avoid things like duplication. >> >> Additionally, I personally prefer details about a contribution to be >> documented in a ticket rather than a PR because information stored in >> tickets are more persistent. Having said that, it doesn't hurt to have the >> details included in the PR as long as it is in the ticket too. Cheers!
