>
> > Until CEP exists and is approved, work on patches in flight seems
> reasonable and valid.
>
> This is right, but when there is an active discussion about changing the
> status quo it's polite to wait for the outcome of the discussion - or help
> it make progress - before making potentially conflicting changes.
>


Totally agree.
This question has been asked many times, and is often getting answered by
fragmented groups. The broader discussion is definitely warranted (thank
you Benjamin).

Stefan, looking at the patch for CASSANDRA-16725, it is only intended for
trunk so it has 6 months to land. I'm definitely in favour of seeing it
also be put into a vtable. It doesn't change the patch much, just an ask
for a trivial class to be added, and that is a reasonable request to make
through the review rounds. (A few rounds during the review like this is
_perfectly normal_, and  is only going to improve the patch in other areas,
like changing the code to use Config.PROPERTY_PREFIX and
CassandraRelevantProperties).
But I can take this feedback to the ticket. Also happy to help out (as any
reviewer that makes a suggestion should be!)

Reply via email to