Cool, I think I fixed the ViewTest by changing from updateView("TRUNCATE %s") to execute("TRUNCATE %s").
I also split it into several smaller unit tests. Patch is here: https://issues.apache.org/jira/browse/CASSANDRA-14280 I haven't got time to look into BatchMetricsTest yet. Thanks Dikang. On Tue, Feb 27, 2018 at 6:00 PM, Jason Brown <jasedbr...@gmail.com> wrote: > All, > > As @kjellman pointed out, the timeouts on ViewTest & ViewBuilderTaskTest > are being addressed in CASSANDRA-14194 > <https://issues.apache.org/jira/browse/CASSANDRA-14194> (I have a patch, > almost ready to release). > > @dikang if you want to refactor those tests for fun, go for it - but note > that the timeouts are currently not due to size. > > I have no idea about the BatchMetricsTest, but I can see if it is related > to the others. @dikang, Do you have any details to share about the > failures? > > -Jason > > On Tue, Feb 27, 2018 at 5:16 PM, Dinesh Joshi < > dinesh.jo...@yahoo.com.invalid> wrote: > > > Yes, give it a go. I am not 100% sure if it will help a whole lot but try > > it out and let's see what happens! > > Dinesh > > > > On Tuesday, February 27, 2018, 2:57:41 PM PST, Dikang Gu < > > dikan...@gmail.com> wrote: > > > > I took some look at the cql3.ViewTest, it seems too big and timeout very > > often. Any objections if I split it into two or multiple tests? > > > > On Tue, Feb 27, 2018 at 1:32 PM, Michael Kjellman <kjell...@apple.com> > > wrote: > > > > > well, turns out we already have a jira tracking the MV tests being > broken > > > on trunk. they are legit broken :) thanks jaso > > > > > > https://issues.apache.org/jira/browse/CASSANDRA-14194 > > > > > > not sure about the batch test timeout there though.. did you debug it > at > > > all by chance? > > > > > > > > > On Feb 27, 2018, at 1:27 PM, Michael Kjellman <kjell...@apple.com > > <mailto: > > > kjell...@apple.com>> wrote: > > > > > > hey dikang: just chatted a little bit about this. proposal: let's add > the > > > equivalent of @resource_intensive to unit tests too.. and the first one > > is > > > to stop from running the MV unit tests in the free circleci containers. > > > thoughts? > > > > > > also, might want to bug your management to see if you can get some paid > > > circleci resources. it's game changing! > > > > > > best, > > > kjellman > > > > > > On Feb 27, 2018, at 12:12 PM, Dinesh Joshi <dinesh.jo...@yahoo.com. > > > INVALID<mailto:dinesh.jo...@yahoo.com.INVALID>> wrote: > > > > > > Some tests might require additional resources to spin up the required > > > components. 2 CPU / 4GB might not be sufficient. You may need to bump > up > > > the resources to 8CPU / 16GB. > > > Dinesh > > > > > > On Tuesday, February 27, 2018, 11:24:34 AM PST, Dikang Gu < > > > dikan...@gmail.com<mailto:dikan...@gmail.com>> wrote: > > > > > > Looks like there are a few flaky/timeout unit tests in trunk, wondering > > is > > > there anyone looking at them already? > > > > > > testBuildRange - org.apache.cassandra.db.view.ViewBuilderTaskTest > > > testUnloggedPartitionsPerBatch - > > > org.apache.cassandra.metrics.BatchMetricsTest > > > testViewBuilderResume - org.apache.cassandra.cql3.ViewTest > > > > > > https://circleci.com/gh/DikangGu/cassandra/20 > > > > > > -- > > > Dikang > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org<mailto: > dev- > > > unsubscr...@cassandra.apache.org> > > > For additional commands, e-mail: dev-h...@cassandra.apache.org<mailto: > > > dev-h...@cassandra.apache.org> > > > > > > > > > > > > > > > -- > > Dikang > > > > > -- Dikang