SelectTest start to be pretty big. It makes sense to splitting it into separate TestClasses. For example we could extract all the filtering tests into a new TestClass: FilteringTest or SelectWithFilteringTest.
On Thu, Sep 15, 2016 at 8:34 AM, Oleksandr Petrov < oleksandr.pet...@gmail.com> wrote: > > CASSANDRA-11031 > > Yes, sorry for delay with #11031 dtests. I've ran updated dtests yesterday > and they were clean to merge. I just wanted to make sure someone else takes > a quick glance. By now they're merged, so hopefully today it's going to be > better. > > As regards environmental timeouts, it looks like certain methods are more > prone to this (in particular, view filtering test does quite a lot). I > realise they don't hang, they just execute slower on CI machine than we > anticipate. But what should we do with it generally? Increasing timeouts > won't really help, so what comes to mind is: > * Splitting tests > * Modularising to make sure unnecessary components don't get started > * Running "slow-prone" tests sequentially to make sure they get enough > processor time > * Taking a deeper look, might be there's a performance issue hiding > behind > * Thread-dumping in case there is some sort of deadlock that's hard to > reproduce on "faster" machine (however improbable that might sound) > > Since it looks like generally tests are in much better shape, it might be a > good point to start thinking about those timing out ones. > > > > > On Thu, Sep 15, 2016 at 7:51 AM Joel Knighton <joel.knigh...@datastax.com> > wrote: > > > cassandra-3.9 > > =================================================== > > testall: 8 failures > > org.apache.cassandra.cql3.ViewFilteringTest > > .testPartitionKeyAndClusteringKeyFilteringRestrictions > > > > org.apache.cassandra.cql3.ViewFilteringTest > > .testMVCreationSelectRestrictions > > > > org.apache.cassandra.cql3.ViewTest.testCompoundPartitionKey > > > > org.apache.cassandra.cql3.validation.entities.UFTest.testEmptyString > > > > org.apache.cassandra.cql3.validation.operations.AggregationTest > > .testFunctionsWithCompactStorage > > > > org.apache.cassandra.cql3.validation.operations.SelectTest > > .testAllowFiltering > > These six test failures are due to environmental timeouts. > > > > org.apache.cassandra.db.compaction > > .TimeWindowCompactionStrategyTest > > .testDropExpiredSSTables-compression > > New flaky failure. CASSANDRA-12645 opened. > > > > org.apache.cassandra.service.RemoveTest.testBadHostId > > CASSANDRA-12487. Flaky failure in a test utility setup method. > > > > =================================================== > > dtest: 1 failure > > user_types_test.TestUserTypes.test_type_as_part_of_pkey > > Should have been fixed as part of CASSANDRA-11031. Incorrect > > version gating still - I'll follow up and get this fixed tomorrow. > > > > =================================================== > > novnode: 4 failures > > user_types_test.TestUserTypes.test_type_as_part_of_pkey > > Same as above. > > > > cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest > > .test_bulk_round_trip_with_single_core > > New failure - looks like a schema agreement problem. A JIRA > > hasn't been created yet. > > > > cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest > > .test_reading_max_insert_errors > > New failure - looks like Netty detected a leak. A JIRA hasn't been > > created yet. > > > > batch_test.TestBatch.logged_batch_doesnt_throw_uae_test > > CASSANDRA-12383. Flaky failure. > > > > =================================================== > > upgrade: 1 failure > > upgrade_tests.cql_tests > > .TestCQLNodes3RF3_Upgrade_current_2_1_x_To_indev_3_x > > .bug_5732_test > > CASSANDRA-12457. Patch available that needs a reviewer. > > > > > > Since there's a few open opportunities based on 3.9 failures, I'm only > > covering 3.9 on today's email. > > > -- > Alex Petrov >
