Hi Chris,

Can you open a ticket at https://issues.apache.org/jira/browse/CASSANDRA ?

On Wed, Aug 1, 2012 at 6:58 PM, canadianveggie <[email protected]> wrote:
> GitHub user canadianveggie opened a pull request:
>
>     https://github.com/apache/cassandra/pull/12
>
>     Fix logic for logging a timeout error when MessagingService is draining
>
>     Fix logic for logging an error if streams don't terminate in 24 hours. 
> Before the logic was backwards. When you called drain, it would log a bunch 
> of incorrect error messages: "Stream took more than 24H to complete; 
> skipping".
>
>     ThreadPoolExecutor.awaitTermination returns true if the executor 
> terminates and false if the timeout elapses before termination.
>
>     
> http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html#awaitTermination%28long,%20java.util.concurrent.TimeUnit%29
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/canadianveggie/cassandra trunk
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/cassandra/pull/12.patch
>
> ----
> commit e681a97ff52684df5381270be27ee49708f94dd8
> Author: Christopher Porter <[email protected]>
> Date:   2012-08-01T16:48:48-07:00
>
>     Log an error if streams don't terminate in 24 hours (logic was backwards)
>     ThreadPoolExecutor.awaitTermination returns true if the executor 
> terminates and false if the timeout elapses before termination.
>
> ----
>



-- 
Jonathan Ellis
Project Chair, Apache Cassandra
co-founder of DataStax, the source for professional Cassandra support
http://www.datastax.com

Reply via email to